guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phas


From: Maxime Devos
Subject: [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phases.
Date: Fri, 11 Mar 2022 23:39:21 +0100
User-agent: Evolution 3.38.3-1

Simon South schreef op za 05-03-2022 om 11:39 [-0500]:
> This occurred to me, but is it not better in this case to rely on the
> "output" parameter passed into the procedure?  Using "#$output" in this
> context feels like a violation of the Law of Demeter, like using a
> global variable where a local one would be appropriate.

'outputs' is an argument to the phase procedure, but as I understand
it, it is only due to historical reasons (G-exps are relatively new-
ish) and because the procedures in (guix build FOO-build-system) have
no other method for determining the outputs.

Might be a good idea to confirm with chief gexpologist ludo though.

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]