[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build.
From: |
Tanguy LE CARROUR |
Subject: |
[bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build. |
Date: |
Wed, 16 Mar 2022 17:48:31 +0100 |
User-agent: |
alot/0.10 |
Hi Liliana,
Quoting Liliana Marie Prikler (2022-03-16 15:02:30)
> Am Mittwoch, dem 16.03.2022 um 14:46 +0100 schrieb Tanguy LE CARROUR:
> > > i.e. (dirname (search-input-file inputs "notmuch.h")) and
> > > (dirname (search-input-file inputs "libnotmuch.so")).
> >
> > Unfortunately, I couldn't make those work. :-(
> >
> > So I ended up with a less "sexy" version:
> >
> > ```
> > "NOTMUCH_INCLUDE_DIR='" (assoc-ref inputs "notmuch")
> > "/include/notmuch.h" "'\n"
> > "NOTMUCH_LIB_DIR='" (assoc-ref inputs "notmuch") "/lib/libnotmuch.so"
> > "'"
> > ```
> That is actually a mistake on my part, search-input-file should search
> inputs for "include/notmuch.h" and likewise "lib/libnotmuch.so". The
> dirname is important here, since both constants want directories.
> Alternatively, forgoing those constants might be a good idea, but is
> not worth investing too much time in.
So, I'm leaving those as they are for now.
> > If I set `NOTMUCH_VERSION_FILE=''`, I get a "file does not exist"
> > error at build time. So I decided to set it to `/dev/null` instead.
> > Or would it be better if I patched `notmuch` to create the actual
> > version file?!
> I think you ought to debug the build and short-circuit the logic by
> inferring the version number directly where it is needed. Without
> actual build output that's as much as I can propose.
Mmm… I've added a new phase to patch the `setup.py`, but couldn't get
the version variable to work. Sorry for my… noobiness!? ^_^'
```
;; version.txt is not included in notmuch, so we patch in the version number
(add-after 'create-notmuch-config 'patch-setup.py
(lambda _
(substitute* "setup.py"
(("with open\\(NOTMUCH_VERSION_FILE\\) as fp:") "")
((" VERSION = fp.read\\(\\).strip\\(\\)") "")
(("version=VERSION,") (string-append "version='" "0.0.0" "',")))))
```
I've tried to replace `0.0.0` with `version` or `,version` but that
doesn't seem to be the proper way to do it.
Regards,
--
Tanguy
0001-WIP-gnu-python-notmuch2-Fix-build.patch
Description: Text Data
- [bug#54396] [PATCH] [WIP] gnu: python-notmuch2: Fix build., Tanguy Le Carrour, 2022/03/15
- [bug#54396] [PATCH] [WIP] gnu: python-notmuch2: Fix build., Liliana Marie Prikler, 2022/03/15
- [bug#54396] [PATCH] [WIP] gnu: python-notmuch2: Fix build., Maxime Devos, 2022/03/15
- [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build., Tanguy Le Carrour, 2022/03/16
- [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build., Liliana Marie Prikler, 2022/03/16
- [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build., Tanguy LE CARROUR, 2022/03/16
- [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build., Liliana Marie Prikler, 2022/03/16
- [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build.,
Tanguy LE CARROUR <=
- [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build., Liliana Marie Prikler, 2022/03/17
- [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build., Tanguy LE CARROUR, 2022/03/17
- [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build., Liliana Marie Prikler, 2022/03/17
- [bug#54396] [PATCH v2] [WIP] gnu: python-notmuch2: Fix build., Tanguy LE CARROUR, 2022/03/17
[bug#54396] [PATCH v6] gnu: python-notmuch2: Fix build., Tanguy Le Carrour, 2022/03/22