guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#53929] [PATCH] gnu: Add python-onlykey


From: Ludovic Courtès
Subject: [bug#53929] [PATCH] gnu: Add python-onlykey
Date: Tue, 05 Apr 2022 18:09:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hi Pāladhammika,

A friendly reminder:

  https://issues.guix.gnu.org/53929

TIA,
Ludo’.

Ludovic Courtès <ludo@gnu.org> skribis:

> Hi Pāladhammika,
>
> Pāladhammika <paladhammika@protonmail.com> skribis:
>
>> I see. Took the Nix package definition as an example 
>> (https://github.com/NixOS/nixpkgs/blob/7adc9c14ec74b27358a8df9b973087e351425a79/pkgs/tools/security/onlykey-cli/default.nix#L25)
>>  which turned off tests.
>
> In Guix the QA standard is to run tests by default.  When tests cannot
> be run for some reason, we add a short comment next to #:tests? #f
> explaining why.
>
> Could you take this and Maxime’s other comments into account and send an
> updated patch?
>
> Thanks in advance!
>
> Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]