guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54847] [PATCH] gnu: Add hyfetch.


From: Jaft
Subject: [bug#54847] [PATCH] gnu: Add hyfetch.
Date: Mon, 11 Apr 2022 17:07:23 +0000 (UTC)

> On Monday, April 11, 2022, 04:02:59 AM CDT, Maxime Devos 
> <maximedevos@telenet.be> wrote:
>
> Wamm K. D schreef op ma 11-04-2022 om 03:01 [-0500]:
> > +    (propagated-inputs (list python-hypy-utils python-typing-extensions))
>
> Do these need to be propagated?

Fair question; that was just what ~guix import pypi hyfetch --recursive~ had 
given me but I tried it out, again, with them just as ~inputs~ and it worked 
just fine so I'll get that adjusted.


> Wamm K. D schreef op ma 11-04-2022 om 03:01 [-0500]:
> > +    (arguments `(#:phases (modify-phases %standard-phases
> > +                            (add-before 'build 'set-HOME
> > +                              (lambda _  ;; Tries to set files in .config
> > +                                (setenv "HOME" "/tmp"))))))
>
> neofetch has #:tests? #false, #:make-flags and no set-home phase.  How
> come this fork doesn't?

If I were to hazard a guess, because this is a Python package/module while the 
other is built with ~make~? I'm afraid I don't know enough to say, otherwise; I 
can say that the package was able to build alright and run fine without 
disabling tests.


> Wamm K. D schreef op ma 11-04-2022 om 03:01 [-0500]:
> > +    (synopsis "@code{neofetch} with pride flags <3")
>
> You are not restricted to ASCII, you can write 🫀, 💓, 💔, 💕, 💖, 💗,
> 💘, 💙, 💚, 💛, 💜, 💝 or 💞 instead of <3.
 >
> What does <3 mean here?

Neat; I didn't know that so thanks for the heads up. I think it's just a heart, 
to be affectionate; it's the synopsis given for the module on pypi.org and, so, 
was pulled in by the import. I always try to stick as much as possible to the 
creator's words for their own software so I just left it in but it's definitely 
far from mandatory in describing what it is the package does. I can remove it, 
if you'd like, or swap the ASCII representation to one of the emojis you 
suggested, if that might make it less ambiguous.


> Wamm K. D schreef op ma 11-04-2022 om 03:01 [-0500]:
> > any ASCII file of your choice
>
> Is it restricted to the ASCII character set, or does any text file do
> and can I put 🫀 in the file as well?

Ummm, another really good question. I was assuming, as its a fork of 
=neofetch=, that the same rules would apply and, so, just borrowed from the 
=neofetch= description, but, checking this out, I'm not sure if =hyfetch= has 
this functionality. I'll remove it from there when I update the ~inputs~.


> Wamm K. D schreef op ma 11-04-2022 om 03:01 [-0500]:
> > +    (home-page "https://github.com/hykilpikonna/HyFetch";)
>
> It's a fork.  Is there some web page tracking upstreaming progress?
> E.g., neofetch could suppport multiple modes, the default 'neofetch'
> when running the 'bin/neofetch' binary, 'hyfetch' when running
> 'bin/hyfetch', etc.
>
> Greetings,
>
> Maxime.

Outside of the GitHub page itself, not that I know of. I'd probably need a bit 
more guidance on how to set something like this up, though. That being said, 
the build process between the two may be more different than similar as 
=hyfetch= is using Python while =neofetch= is just using a plain Makefile; the 
old Makefile for =neofetch= is still in the repo., unaltered, so I'm not sure 
how much direct overlap with the original code still exists, for =hyfetch=. I'm 
not sure how much of a difference any of that makes but thought I'd, at least, 
make note.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]