[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54986] [PATCH v2 3/3 WIP] services: mpd: Support socket activation.
From: |
Ludovic Courtès |
Subject: |
[bug#54986] [PATCH v2 3/3 WIP] services: mpd: Support socket activation. |
Date: |
Thu, 28 Apr 2022 00:08:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> * gnu/services/audio.scm (<mpd-configuration>)[shepherd-endpoints]: New field.
> (mpd-shepherd-service): Use it.
> * doc/guix.texi (Music Player Daemon): Document it.
[...]
> +++ b/gnu/services/audio.scm
> @@ -78,6 +78,8 @@ (define-record-type* <mpd-configuration>
> (default "6600"))
> (address mpd-configuration-address
> (default "any"))
> + (shepherd-endpoints mpd-configuration-shepherd-endpoints
> + (default '())) ; list of <shepherd-endpoint>
The way I see it, service configuration should be oblivious to whether
it’s started as “forkexec”, systemd, or inetd.
There’s already an ‘address’ field above, so my suggestion would be to
reuse it. This is what I did for example for the openssh service, and
also for bitlbee and dicod here:
https://issues.guix.gnu.org/54997#5
WDYT?
Thanks,
Ludo’.
- [bug#54986] [PATCH] gnu: mpd: Add support for socket activation., (continued)
[bug#54986] [PATCH v2 1/3] gnu: mpd: Add support for socket activation., Liliana Marie Prikler, 2022/04/23
[bug#54986] [PATCH v2 3/3 WIP] services: mpd: Support socket activation., Liliana Marie Prikler, 2022/04/23
[bug#54986] [PATCH v2 2/3 WIP] services: shepherd: Add support for socket activation endpoints., Liliana Marie Prikler, 2022/04/23