[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options.
From: |
Maxim Cournoyer |
Subject: |
[bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options. |
Date: |
Sat, 21 May 2022 21:25:25 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi Mathieu!
Mathieu Othacehe <othacehe@gnu.org> writes:
> Also factorize the --system and --target build options. Check that the passed
> system and target arguments are known platforms.
>
> * doc/guix.texi (Additional Build Options): Document the new --list-systems
> and --list-targets options.
This is a very welcome change, thanks a lot for tackling it!
[...]
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 5399584cb0..22a8ee7d2d 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -12025,6 +12025,14 @@ Cross-build for @var{triplet}, which must be a valid
> GNU triplet, such
> as @code{"aarch64-linux-gnu"} (@pxref{Specifying Target Triplets, GNU
> configuration triplets,, autoconf, Autoconf}).
>
> +@item --list-systems
> +List all the supported systems, than can be passed as @var{system}
^ that
> +argument.
> +
> +@item --list-targets
> +List all the supported targets, than can be passed as @var{target}
> +argument.
Likewise.
> @anchor{build-check}
> @item --check
> @cindex determinism, checking
> diff --git a/guix/scripts/archive.scm b/guix/scripts/archive.scm
> index f8678aa5f9..991919773a 100644
> --- a/guix/scripts/archive.scm
> +++ b/guix/scripts/archive.scm
> @@ -93,14 +93,14 @@ (define (show-help)
> (display (G_ "
> -S, --source build the packages' source derivations"))
> (display (G_ "
> - -s, --system=SYSTEM attempt to build for SYSTEM--e.g., \"i686-linux\""))
> - (display (G_ "
> - --target=TRIPLET cross-build for TRIPLET--e.g.,
> \"armel-linux-gnu\""))
> - (display (G_ "
> -v, --verbosity=LEVEL use the given verbosity LEVEL"))
>
> (newline)
> (show-build-options-help)
> + (newline)
> + (show-cross-build-options-help)
> + (newline)
> + (show-emulated-build-options-help)
I have a bit of a problem with the "emulated" part of the name, as
--system not only targets emulated machines but also different native
machines of that architecture via offloading :-). Perhaps,
'show-foreign-build-options-help', but I'm not sure that's an
improvement.
I've lost a bit focus for the remaining of the patch, but it LGTM.
Thanks again for tackling this so swiftly after it was brought up on an
issue.
Maxim
[bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options., Ludovic Courtès, 2022/05/06
[bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options., Ludovic Courtès, 2022/05/06
[bug#55220] [PATCH v2 0/6] Add --list-systems and --list-targets options., Mathieu Othacehe, 2022/05/07