[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55891] [PATCH] gnu: Add iec16022
From: |
Remco van 't Veer |
Subject: |
[bug#55891] [PATCH] gnu: Add iec16022 |
Date: |
Sat, 11 Jun 2022 09:09:34 +0200 |
User-agent: |
mu4e 1.6.11; emacs 28.1 |
2022/06/10 23:47, Maxime Devos:
> Remco van 't Veer schreef op vr 10-06-2022 om 19:39 [+0200]:
>> > Contains a bug: on line
>> >
>> > https://github.com/rdoeffinger/iec16022/blob/c9a9fd926fd1e6cca9782fe3f8c2bab66010ca51/image.c#L284
>> >
>> > , it allocates a buffer, which can fail (by returning NULL).
>> > It then passes the possibly NULL buffer to compress2.
>> > Also, it writes files without checking for errors
>> > (e.g. EIO, ENOSPC or EDQUOT).
>>
>> Good catch! I'll need to brush up on my C skills to fix these.
>> Meanwhile I'd like to ship including bugs, WDYT?
>
> I think it's ok, _if_ the bugs are eventually at least reported
> upstream if we (i.e., you) cannot fix them timely (needs some contrived
> circumstances to trigger the bug).
https://github.com/rdoeffinger/iec16022/pull/17
[bug#55891] [PATCH v2] gnu: Add iec16022., Remco van 't Veer, 2022/06/10
[bug#55891] [PATCH v3] gnu: Add iec16022., Remco van 't Veer, 2022/06/10