[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55997] [PATCH staging 1/4] gnu: Add ruby-hydra-minimal.
From: |
Thiago Jung Bauermann |
Subject: |
[bug#55997] [PATCH staging 1/4] gnu: Add ruby-hydra-minimal. |
Date: |
Sun, 19 Jun 2022 18:36:21 -0300 |
Hello Tom,
Nice series! Thanks for tackling this issue.
I read all patches, and have only one minor suggestion about this one,
apart from what Maxime already mentioned.
Tom Fitzhenry <tom@tom-fitzhenry.me.uk> writes:
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -3124,24 +3124,39 @@ (define-public ruby-hashdiff
> (home-page "https://github.com/liufengyun/hashdiff")
> (license license:expat)))
>
> -(define-public ruby-hydra
> +(define-public ruby-hydra-minimal
> ;; No releases yet.
> (let ((commit "5abfa378743756ae4d9306cc134bcc482f5c9525")
> (revision "0"))
> (package
> - (name "ruby-hydra")
> + (name "ruby-hydra-minimal")
> (version (git-version "0.0" revision commit))
> (home-page "https://github.com/hyphenation/hydra")
> (source (origin
> (method git-fetch)
> (uri (git-reference (url home-page) (commit commit)))
> (file-name (git-file-name name version))
> + ;; byebug is a non-essential debugging utility that brings in
> + ;; many dependencies.
> + (patches (search-patches "ruby-hydra-no-byebug.patch"))
> (sha256
> (base32
> "1cik398l2765y3d9sdhjzki3303hkry58ac6jlkiy7iy62nm529f"))))
> (build-system ruby-build-system)
> (arguments
> - '(#:phases (modify-phases %standard-phases
> + ;; Avoid rspec dependency.
> + '(#:tests? #f))
> + (synopsis "Ruby hyphenation patterns")
> + (description
> + "ruby-hydra-minimal is a Ruby library for working with hyphenation
> patterns. It is a low-dependency variant of ruby-hydra.")
guix lint has two complaints about this description:
gnu/packages/ruby.scm:3151:7: ruby-hydra-minimal@0.0-0.5abfa37:
sentences in description should be followed by two spaces; possible
infraction at 74
gnu/packages/ruby.scm:3151:0: ruby-hydra-minimal@0.0-0.5abfa37: line
3151 is way too long (131 characters)
One suggestion to solve both is to put the second sentence in its own line.
> + (license license:expat))))
> +
> +(define-public ruby-hydra
> + (package
> + (inherit ruby-hydra-minimal)
> + (name "ruby-hydra")
> + (arguments
> + '(#:phases (modify-phases %standard-phases
> (add-after 'unpack 'make-files-writable
> (lambda _
> (for-each make-file-writable (find-files "."))
When I saw this patch I thought that ruby-hydra would also inherit the
â#:tests? #fâ argument from its parent, but this construction overrides
the whole arguments list instead. Nice, I learned something new today. :-)
--
Thanks
Thiago
[bug#55997] [PATCH staging v2 0/5] Remove texlive's dependence on mariadb., Tom Fitzhenry, 2022/06/24
- [bug#55997] [PATCH staging v2 1/5] gnu: Add ruby-hydra-minimal., Tom Fitzhenry, 2022/06/24
- [bug#55997] [PATCH staging v2 2/5] gnu: Remove texlive's dependence on ruby-rspec and ruby-byebug., Tom Fitzhenry, 2022/06/24
- [bug#55997] [PATCH staging v2 3/5] gnu: Unpin ruby-nokogiri-diff's ruby-nokogiri, Tom Fitzhenry, 2022/06/24
- [bug#55997] [PATCH staging v2 4/5] gnu: Remove unused ruby-nokogiri-1.10., Tom Fitzhenry, 2022/06/24
- [bug#55997] [PATCH staging v2 5/5] gnu: texlive-hyphen-package: Remove input labels., Tom Fitzhenry, 2022/06/24
- [bug#55997] [PATCH staging v2 0/5] Remove texlive's dependence on mariadb., Tom Fitzhenry, 2022/06/29