[bug#56579] [PATCH] gnu: admin: Add fail2ban 0.11.2.

[muradm]

Hi, I think you are commenting on initial versions.
Please refer to last v5, which is quite crafted.

Jean Pierre De Jesus DIAZ <me@jeandudey.tech> writes:

> Hello muradm!
>
> > +    (arguments
> > +     '(#:phases (modify-phases %standard-phases
>
> I think you can benefit a little bit from using G-Expressions 
> here:
>
> (arguments
>   (list #:phases
>         #~(modify-phases %modify-phases
>             ...)))
>
> For example:
>
> > +                      (let* ((awk (assoc-ref inputs "gawk"))
> > +                             (awk (string-append awk 
> > "/bin/awk"))
>
> Could be replaced by:
>
> (let* ((awk (string-append #$gawk "/bin/awk"))))
>
> Applies to others too. Could save some vertical space.
>
> —
> Jean-Pierre De Jesus DIAZ

signature.asc
Description: PGP signature