[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#56831] [PATCH] gnu: mumps: Update to 5.5.1
From: |
Ludovic Courtès |
Subject: |
[bug#56831] [PATCH] gnu: mumps: Update to 5.5.1 |
Date: |
Thu, 04 Aug 2022 12:17:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi Marek,
FELŠÖCI Marek <marek@felsoci.sk> skribis:
> - (patches (search-patches "mumps-build-parallelism.patch"
> - "mumps-shared-libseq.patch"
> - "mumps-shared-mumps.patch"
> - "mumps-shared-pord.patch"))))
Good to see them go. :-)
Could you please also remove the files and remove them from
‘gnu/local.mk’?
> - `(#:modules ((ice-9 match)
> - (ice-9 popen)
> - (srfi srfi-1)
> - ,@%gnu-build-system-modules)
> + `(#:modules
> + ((ice-9 match)
> + (ice-9 popen)
> + (srfi srfi-1)
> + ,@%gnu-build-system-modules)
This is unnecessary; if you could avoid it, that’d be great: it’d make
the important changes more visible.
> #:phases
> (modify-phases %standard-phases
> (replace 'configure
> - (lambda* (#:key inputs #:allow-other-keys)
> - (call-with-output-file "Makefile.inc"
> - (lambda (port)
Looks like this hunk is mostly reformatting as well?
> + (assoc-ref inputs "openblas")
> + (->bool ;; OpenBLAS or MKL?
> + (file-exists?
> + (string-append
> + (assoc-ref inputs "openblas")
> + "/include/mkl_cblas.h")))
I understand the intent and that’s fine, but I would prefer a solution
that does not explicitly refer to MKL. Perhaps we could devise a
solution that, more generally, allows users to swap one BLAS for
another, but maybe that’s beyond the scope of this patch.
Could you send a v2 of the patch that addresses these comments?
Bonus points if you can provide a commit log that follows the ChangeLog
style:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
:-)
Thank you,
Ludo’.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#56831] [PATCH] gnu: mumps: Update to 5.5.1,
Ludovic Courtès <=