[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#55682] [PATCH V2 1/3] gnu: Add lcrq.

From: Maxime Devos
Subject: [bug#55682] [PATCH V2 1/3] gnu: Add lcrq.
Date: Thu, 11 Aug 2022 11:48:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0

On 31-07-2022 01:41, Vagrant Cascadian wrote:
+                  (replace 'check
+                    (lambda _
+                      (invoke "make" "test"))))))

I expect "./pre-inst-env guix lint lcrq" to have a warning about respecting #:tests?. This is important for --without-tests and cross-compilation. Likewise for the other patches.

+       #:make-flags (let ((target ,(%current-target-system)))
+                      (list ,(string-append "CC="
+                                            (cc-for-target))
+                            (string-append "PREFIX="
+                                           (assoc-ref %outputs "out"))))
'target' is unused and can be removed.


Attachment: OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]