[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57298] [PATCH 3/5] gnu: Add ocaml-crowbar.
From: |
pukkamustard |
Subject: |
[bug#57298] [PATCH 3/5] gnu: Add ocaml-crowbar. |
Date: |
Mon, 22 Aug 2022 09:45:37 +0000 |
Julien Lepiller <julien@lepiller.eu> writes:
> Le Fri, 19 Aug 2022 15:24:30 +0000,
> pukkamustard <pukkamustard@posteo.net> a écrit :
>
>> + (build-system dune-build-system)
>> + (arguments
>> + ;; Tests require ocaml-xmldiff which requires OCaml 4.12.0
>> + `(#:tests? #f))
>
> That doesn't seem to be the case, at least from opam, the constraint is
> ocaml >= 4.12. We have 4.14. Could you try adding xmldiff and enabling
> tests?
Again, this seems to have been an artifact of porting the package
definitions from an old patch series. Sorry for the sloppyness.
ocaml-crowbar no longer has tests that rely on xmldiff. I've enabled the
tests and it just works.
A general note on another OCaml dependency: ocaml-calendar seems to be
unmaintained
(https://discuss.ocaml.org/t/calendarlib-looking-for-a-new-maintainer/3965)
and some fixes are included in an unreleased Git branch
(https://github.com/ocaml-community/calendar/tree/3.x). No action
required from Guix side at the moment, just worth keeping in mind.
Thanks for your review! Will send in V2 shortly.
-pukkamustard
>
>> + (propagated-inputs
>> + (list ocaml-ocplib-endian
>> + ocaml-cmdliner
>> + ocaml-afl-persistent))
>> + (native-inputs
>> + (list ocaml-calendar
>> + ocaml-fpath
>> + ocaml-uucp
>> + ocaml-uunf
>> + ocaml-uutf
>> + ocaml-pprint))
>> + (synopsis "Ocaml library for tests, let a fuzzer find failing
>> cases")
>> + (description "Crowbar is a library for testing code, combining
>> +QuickCheck-style property-based testing and the magical bug-finding
>> powers of +@uref{http://lcamtuf.coredump.cx/afl/, afl-fuzz}.")
>> + (license license:expat)))
>> +
>> (define-public ocaml-bibtex2html
>> (package
>> (name "ocaml-bibtex2html")
[bug#57298] [PATCH v2 1/5] gnu: Add ocaml-afl-persistent., pukkamustard, 2022/08/22