[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#57387] [PATCH] gnu: Add restartd.

From: Maxime Devos
Subject: [bug#57387] [PATCH] gnu: Add restartd.
Date: Wed, 24 Aug 2022 20:09:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0

On 24-08-2022 17:59, Nicolas Graves via Guix-patches via wrote:

+         (revision "1.1"))

"1.1" -> "1" ('revision' must be a string with a number, as expected by

Also, why is an unreleased version used? I assume because of lack of activity upstream, but a comment would have been useful.

+                (substitute* "Makefile"
+                  (("CC \\?= gcc") "CC = gcc"))))
For cross-compilation, use (cc-for-target)

According to Debian, the home-page is <>.

Looking at some source files, it appears to be gpl2-or-later, not gpl2-only.

In restartd.c, it is missing error checking for 'fopen', 'malloc' and 'strdup'.

in config.c, it is missing error checking for 'malloc'  (and for printf on stderr, but there isn't much that can be odone in that case). Also printf on stdout, though less important.

On the patches: IIUC, in case additional commits are added to the PR, the patch is updated appropriately, so these patches are volatile. Even if that doesn't happen, the patch generation algorithm could change later. As such, copying these into gnu/packages/patches + search-pathes is recommended

You can execute a script or a program if the process is or is not running.
Maybe: 'The daemon runs an user-provided script based once a program starts running or stops running.' That seems a little clearer English to me ('it is running or not running' is always true, and scripts / programs can be run, but it's not a claim about restartd).


Attachment: OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]