[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#57419] [PATCH] gnu: add python-grid5000
From: |
Marius Bakke |
Subject: |
[bug#57419] [PATCH] gnu: add python-grid5000 |
Date: |
Mon, 29 Aug 2022 18:09:30 +0200 |
Hi Matthieu,
Welcome to Guix! The patch looks good overall, a few minor questions:
> +(define-public python-grid5000
> + (package
> + (name "python-grid5000")
> + (version "1.2.3")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.inria.fr/msimonin/python-grid5000")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + "097pm8b68ihk29xz9zv29b1x0bhgjb4lfj8zxk2grbsh7wr9dipg")))
> + (build-system python-build-system)
> + (native-inputs (list python-wheel))
> + (propagated-inputs (list python-requests python-ipython python-pyyaml))
> + (arguments
> + (list #:tests? #f))
Can you add a comment stating why tests are disabled?
> + (home-page "https://pypi.org/project/python-grid5000/")
> + (synopsis "Grid5000 python client")
> + (description
> + "python-grid5000 is a python package wrapping the Grid5000 REST API.
> + You can use it as a library in your python project or you can
> + explore the Grid5000 resources interactively using the embedded shell.")
> + (license license:gpl3)))
The LICENSE.txt file says LGPL3, setup.cfg says GPL3. Which is
correct? :-)
Also, unless otherwise noted in the source code (e.g. "version 3 only"),
it should be "gpl3+", i.e. "and any later version".
Can you send an updated patch?
Thanks in advance!
signature.asc
Description: PGP signature