[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#56777] [PATCH] Use absolute path for home activation script.
From: |
Ludovic Courtès |
Subject: |
[bug#56777] [PATCH] Use absolute path for home activation script. |
Date: |
Mon, 29 Aug 2022 23:24:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi Andrew,
Andrew Tropin <andrew@trop.in> skribis:
> * gnu/home/services.scm (compute-activation-script): Use absolute path for
> home activation script.
>
> ---
> gnu/home/services.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/home/services.scm b/gnu/home/services.scm
> index b05ec53e2a..6d5e4308a0 100644
> --- a/gnu/home/services.scm
> +++ b/gnu/home/services.scm
> @@ -418,7 +418,7 @@ (define (compute-activation-script init-gexp gexps)
> (new-home-env (getenv "GUIX_NEW_HOME"))
> (new-home (or new-home-env
> ;; Path of the activation file if called
> interactively
> - (dirname (car (command-line)))))
> + (canonicalize-path (dirname (car
> (command-line))))))
Just wondering: what’s the rationale?
This is harmless-looking and perhaps it’s all fine, but IME calling
‘canonicalize-path’ might sometimes paper over problems related to file
name handling.
Thanks,
Ludo’.
- [bug#56777] [PATCH] Use absolute path for home activation script.,
Ludovic Courtès <=