[bug#57675] [PATCH v9 7/8] gnu: telegram-desktop: Update to 4.2.0.

[Liliana Marie Prikler]

Am Donnerstag, dem 22.09.2022 um 10:27 +0800 schrieb Hilton Chain:
> -     (list #:tests? #f                      ; No target
> +     (list #:tests? #f                  ;No target
Refrain from making gratuitous changes like this one...

> -           #~(list
> -              ;; Client applications must provide their own API-ID
> and API-HASH,
> -              ;; see also
> <https://core.telegram.org/api/obtaining_api_id>.
> -              ;; Here, we snarf the keys from the official Snaps,
> which are
> -              ;; also stored in <#$source/snap/snapcraft.yaml>.
> -              "-DTDESKTOP_API_ID=611335"
> -              "-DTDESKTOP_API_HASH=d524b414d21f4d37f08684c1df41ac9c"
> -              ;; Disable WebkitGTK support as it fails to link
> -              "-DDESKTOP_APP_DISABLE_WEBKITGTK=ON"
> -              ;; Use bundled fonts as fallback.
> -              "-DDESKTOP_APP_USE_PACKAGED_FONTS=OFF")
> +           #~`(;; Client applications need an API ID and hash, see
> also:
> +               ;; <https://core.telegram.org/api/obtaining_api_id>.
> Here, we
> +               ;; use the ones given by the official Snap package,
> see:
> +               ;;
> <https://github.com/telegramdesktop/tdesktop/blob/dev/snap/snapcraft.
> yaml>.
> +               "-DTDESKTOP_API_ID=611335"
> +               "-
> DTDESKTOP_API_HASH=d524b414d21f4d37f08684c1df41ac9c"
> +               "-DTDESKTOP_DISABLE_LEGACY_TGVOIP=ON"
> +               "-DDESKTOP_APP_DISABLE_CRASH_REPORTS=ON"
> +               "-DDESKTOP_APP_DISABLE_AUTOUPDATE=ON"
> +               "-DDESKTOP_APP_USE_PACKAGED_RLOTTIE=ON"
> +               ,(string-append "-DTDESKTOP_LAUTCHER_BASENAME="
... or this one.  Neither improve the package.


> -             ((guix build glib-or-gtk-build-system)
> -              #:prefix glib-or-gtk:)
> +             ((guix build glib-or-gtk-build-system) #:prefix glib-
> or-gtk:)
This change is dubious too – while it fits in 80 characters, it just as
well fits in two lines, plus it's a cosmetic change mixed with
functional ones.

>   
> #$name))
>             #:phases
>             #~(modify-phases %standard-phases
>                 (add-after 'unpack 'make-writable
>                   (lambda _
>                     (for-each make-file-writable (find-files "."))))
> -               (add-after 'make-writable 'copy-inputs
> +               (add-after 'make-writable 'copy-sources
Maybe we should make this an after unpack 'unpack-additional-sources.


As for the submodule suggestion, explicit is better than implicit. 
#:recursive? #t might be nice for personal testing, but on a distro
scale it's asking for trouble, especially with upgrades as you never
know what additional sources get pulled in or not and whether your
cleanup still does what it should.  Thus, we typically discourage its
use and Telegram is one of the prime examples of why *not* to apply it.

Cheers