[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-u
From: |
Ludovic Courtès |
Subject: |
[bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities. |
Date: |
Sun, 04 Dec 2022 17:20:42 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Rationale: It is only used in INSTALLATION-OS and doesn't make sense to be
> used in another context, given that file systems now automatically pull their
> dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (services:
> Add file system utilities to profile).
>
> * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename to...
> * gnu/system/install.scm (%installer-disk-utilities): ... this.
> (installation-os) [packages]: Adjust accordingly.
Efraim, this variable was added in
e6e076281e62518056987e9ddd3d96fccab20475 and used in
4170af491c8bc3b0a5308116a26e758d8ff245c5; do you think it’s okay to
remove now? (It LGTM, but I’d like to make sure we don’t create churn.)
> +(define-deprecated %base-packages-disk-utilities #f '())
‘#f’ here would lead to weird deprecation messages. I’d make it:
(define-deprecated %base-packages-disk-utilities %base-packages '())
This is not quite accurate but it should convey the idea.
Thanks,
Ludo’.