[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60997] [PATCH 1/4] gnu: Add python-cmseq.
From: |
Ricardo Wurmus |
Subject: |
[bug#60997] [PATCH 1/4] gnu: Add python-cmseq. |
Date: |
Tue, 24 Jan 2023 09:36:39 +0100 |
User-agent: |
mu4e 1.8.13; emacs 28.2 |
Hi Mădălin,
> * gnu/packages/bioinformatics.scm (python-cmseq): New variable.
Thanks for the patch.
Unfortunately, this is incomplete:
- The tool calls out to samtools (see cmseq/cmseq.py), so it needs
samtools as an input and the call needs to be patched.
- The README says that biopython <= 1.76 is needed for polymut.py.
You’re using 1.80.
> + (build-system python-build-system)
Please consider using the pyproject-build-system.
> + (arguments
> + (list #:tests? #f )) ;pypi no tests
Apparantly, there are no tests anywhere. It’s not a pypi problem.
Please update the comment and remove that extra space after #f.
> + (home-page "http://github.com/SegataLab/cmseq/")
Please use HTTPS. “guix lint” informs you about the redirect.
--
Ricardo