guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#59078] [PATCH] lint: Split the derivation lint checker by system.


From: zimoun
Subject: [bug#59078] [PATCH] lint: Split the derivation lint checker by system.
Date: Wed, 01 Feb 2023 10:47:08 +0100

Hi Ludo,

On Tue, 31 Jan 2023 at 17:33, Ludovic Courtès <ludo@gnu.org> wrote:

> In general, being able to tell which category a checker belongs to, and
> then being able to select checkers by categories sounds like a useful
> improvement to me.
>
> I don’t think it solves the problem Christopher initially reported
> though (about memory consumption of the ‘derivation’ checker.)

Indeed.  My understanding of the proposal is to split some checkers (as
derivation) and then group them to have the expected behaviour.  You
wrote [1]:

        I meant that it’s important to have a single ‘derivation’
        checker that checks derivations for all the supported systems.
        Packagers should be able to run ‘guix lint -c derivation PKG’
        and be confident that it’s fine for all systems.

and Chris answered [2]:

        I think we can still keep that by adding support for grouping
        lint checkers. So have a derivation group, instead of a single
        checker.

        Maybe that'll change the command slightly to 'guix lint -g derivation
        PKG', but I think that can be equivalent.

where I try to feed Chris’s proposal. :-)

I do not know if it is the correct level but being able to run “smaller“
checkers appears to me worth to try.

1: http://issues.guix.gnu.org/msgid/87h6z1puli.fsf@gnu.org
2: http://issues.guix.gnu.org/msgid/87leocfsnm.fsf@cbaines.net

Cheers,
simon





reply via email to

[Prev in Thread] Current Thread [Next in Thread]