[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60899] [PATCH 00/25] gnu: golang: Add gopls
From: |
Katherine Cox-Buday |
Subject: |
[bug#60899] [PATCH 00/25] gnu: golang: Add gopls |
Date: |
Tue, 07 Feb 2023 09:02:12 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Christopher Baines <mail@cbaines.net> writes:
> "(" <paren@disroot.org> writes:
>
>> [[PGP Signed Part:Undecided]]
>> On Mon Feb 6, 2023 at 11:14 PM GMT, Christopher Baines wrote:
>>> I've made a few tweaks and pushed this to master as
>>> f3ab5888a0bc6446104ddbba41a413a86eb298e2.
>>
>> Nooo, my review was too slow :P
>
> I think reviewing changes/sending feedback after things have been merged
> is fine (and important). If more people get involved in reviewing
> things, this is probably something that'll happen more, so I think for
> now it's good to embrace it.
>
> Hopefully we can continue the discussion around these changes and
> perhaps further improve things with some additional patches.
>
> Chris
I responded to Chris's original message, but: +1 to what Chris says. I'm
still going to look at your feedback, paren, and maybe send some more
patches.
Personally, I prefer always moving forward, so long as it doesn't break
anything.
Thank you very much for the reviews!
--
Katherine