[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60904] [PATCH 05/25] gnu: Add go-github-com-google-safehtml.
From: |
Katherine Cox-Buday |
Subject: |
[bug#60904] [PATCH 05/25] gnu: Add go-github-com-google-safehtml. |
Date: |
Tue, 07 Feb 2023 09:41:08 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
"( via Guix-patches" via <guix-patches@gnu.org> writes:
> * gnu/packages/golang.scm (go-github-com-google-safehtml): New variable.
>
>> --- a/gnu/packages/golang.scm
>> +++ b/gnu/packages/golang.scm
>
>> @@ -10921,6 +10921,31 @@ (define-public go-github-com-google-go-jsonnet
>
>> + (propagated-inputs `(("go-golang-org-x-text" ,go-golang-org-x-text)))
>
> Please use new-style inputs.
Ugh, +1, and sorry I missed this. I don't know why the importer doesn't
do this by default yet. I suppose that's another patch that needs to
happen.
I also don't know why `guix style` and `guix lint` didn't catch this.
>> + (synopsis "Safe HTML for Go")
>
> (synopsis "Go type for storing HTML data")
(see other response, wondering if we should take upstream synopses or
not)
>> + (description
>> + "Package safehtml provides immutable string-like types which represent
>> values
>> +that are guaranteed to be safe, by construction or by escaping or
>> sanitization,
>> +to use in various HTML contexts and with various DOM APIs.")
>
> (description
> "This package provides a Go library for storing HTML data as an immutable
> string-like
> value.")
I disagree with this suggestion: the extra context about construction or
escaping takes me from "why would I want to store HTML data in a
struct", to, "oh this is a way to preclude passing around invalid/unsafe
HTML around".
--
Katherine