[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#61226] Decouple w3m from xdg-utils test suite
From: |
Maxim Cournoyer |
Subject: |
[bug#61226] Decouple w3m from xdg-utils test suite |
Date: |
Wed, 08 Feb 2023 23:06:29 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Leo Famulari <leo@famulari.name> writes:
> * gnu/packages/freedesktop.scm (xdg-utils)[native-inputs]: Replace w3m with
> w3m-for-tests.
> [arguments]: Use #:disallowed-references to prevent keeping a reference to
> w3m-for-tests.
> ---
> gnu/packages/freedesktop.scm | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index a986c8c350..677ab5fdf2 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -482,7 +482,7 @@ (define-public xdg-utils
> "1nai806smz3zcb2l5iny4x7li0fak0rzmjg6vlyhdqm8z25b166p"))))
> (build-system gnu-build-system)
> (native-inputs
> - (list docbook-xsl docbook-xml-4.1.2 libxslt w3m xmlto))
> + (list docbook-xsl docbook-xml-4.1.2 libxslt w3m-for-tests xmlto))
> (inputs
> `(("awk" ,gawk)
> ;; TODO(staging): Make this unconditional, to avoid canonical
> packages,
> @@ -501,7 +501,9 @@ (define-public xdg-utils
> ("xprop" ,xprop) ; for Xfce detecting
> ("xset" ,xset))) ; for xdg-screensaver
> (arguments
> - `(#:tests? #f ; no check target
> + `(; Ensure we don't keep a reference to this old version of w3m
I was confused by the "old version". Perhaps rephrase to "[...] this
potentially old version [...]" ?
> + #:disallowed-references (,w3m-for-tests)
> + #:tests? #f ; no check target
> #:modules ((srfi srfi-26)
> ,@%gnu-build-system-modules)
> #:phases
Otherwise, LGTM!
--
Thanks,
Maxim
- [bug#61226] [PATCH 1/5] gnu: linux-libre: Update to 6.1.9., (continued)
- [bug#61226] [PATCH 1/5] gnu: linux-libre: Update to 6.1.9., Leo Famulari, 2023/02/02
- [bug#61226] [PATCH 2/5] gnu: linux-libre 5.15: Update to 5.15.91., Leo Famulari, 2023/02/02
- [bug#61226] [PATCH 4/5] gnu: Add a pinned-version variant of w3m., Leo Famulari, 2023/02/02
- [bug#61226] [PATCH 5/5] gnu: xdg-utils: Use a pinned version of w3m., Leo Famulari, 2023/02/02
- [bug#61226] [PATCH 3/5] gnu: linux-libre 5.10: Update to 5.10.166., Leo Famulari, 2023/02/02
- [bug#61226] [PATCH 1/5] gnu: linux-libre: Update to 6.1.9., Leo Famulari, 2023/02/03
- [bug#61226] Decouple w3m from xdg-utils test suite, André Batista, 2023/02/02
- [bug#61226] [PATCH v2 1/2] gnu: Add a pinned-version variant of w3m., Leo Famulari, 2023/02/03