[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#61686] [PATCH] gnu: Add dropwatch.
From: |
Nicolas Goaziou |
Subject: |
[bug#61686] [PATCH] gnu: Add dropwatch. |
Date: |
Fri, 24 Feb 2023 11:44:50 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
Bruno Victal <mirai@makinata.eu> writes:
> * gnu/packages/networking.scm (dropwatch): New variable.
Thanks.
> ---
> Note: the kernel option NET_DROP_MONITOR must be set for this package
> to work.
Do you think it is worth mentioning in the description? AFAICT, Guix
does not set this option by default.
> +(define-public dropwatch
> + (package
> + (name "dropwatch")
> + (version "1.5.4")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/nhorman/dropwatch.git")
You can drop the ".git" suffix here.
> + (commit (string-append "v" version))))
You also need to add
(file-name (git-file-name name version))
for proper naming in the store.
> + (sha256
> + (base32
> + "1r653y7bx763fpxl1vrflx8bzcrbds98zk4z7yhfikjngrqn1f2d"))))
> + (build-system gnu-build-system)
> + ;; XXX: bfd support isn't finished.
> + ;; https://github.com/nhorman/dropwatch/issues/76#issuecomment-1328345444
> + (arguments
> + (list #:configure-flags #~(list "--without-bfd")))
> + (native-inputs (list autoconf automake pkg-config))
> + (inputs (list libnl libpcap readline))
> + (home-page "https://github.com/nhorman/dropwatch")
> + (synopsis "Kernel dropped packet monitor")
> + (description
> + "dropwatch is an interactive utility for monitoring and
Nicpick: dropwatch —> Dropwatch
> +recording packets that are dropped by the kernel. It provides the commands
You need separate sentences with two spaces, per Texinfo syntax.
> +@command{dropwatch} and @command{dwdump}.")
> + (license license:gpl2+)))
Regards,
--
Nicolas Goaziou