[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#61829] [PATCH 11/11] guix: packages: Remove 'origin-sha256' procedu
From: |
Simon Tournier |
Subject: |
[bug#61829] [PATCH 11/11] guix: packages: Remove 'origin-sha256' procedure. |
Date: |
Tue, 28 Feb 2023 13:57:49 +0100 |
Hi,
On lun., 27 févr. 2023 at 00:11, Bruno Victal <mirai@makinata.eu> wrote:
> - origin-sha256 ;deprecated
[...]
> -(define-deprecated (origin-sha256 origin)
> - origin-hash
> - (let ((hash (origin-hash origin)))
> - (unless (eq? (content-hash-algorithm hash) 'sha256)
> - (raise (condition (&message
> - (message (G_ "no SHA256 hash for origin"))))))
> - (content-hash-value hash)))
Similarly as previously, I would not remove this without more
advertisement.
> diff --git a/tests/import-utils.scm b/tests/import-utils.scm
> index 44dff14597..1565dd610a 100644
> --- a/tests/import-utils.scm
> +++ b/tests/import-utils.scm
> @@ -141,7 +141,7 @@ (define-module (test-import-utils)
> (license:license? (package-license pkg))
> (build-system? (package-build-system pkg))
> (origin? (package-source pkg))
> - (equal? (origin-sha256 (package-source pkg))
> + (equal? (content-hash-value (origin-hash (package-source pkg)))
This LGTM although this test was for testing origin-sha256 specifically,
I guess. :-)
Cheers,
simon
- [bug#61829] [PATCH 01/11] gnu: Purge pre-1.3.0 deprecated packages., (continued)
- [bug#61829] [PATCH 05/11] services: base: Remove 'console-keymap-service-type' variable., Bruno Victal, 2023/02/26
- [bug#61829] [PATCH 03/11] services: ntp-service-type: Remove deprecated server as strings support., Bruno Victal, 2023/02/26
- [bug#61829] [PATCH 09/11] services: desktop: Remove 'mate-desktop-service' procedure., Bruno Victal, 2023/02/26
- [bug#61829] [PATCH 02/11] gnu: curl-minimal: Remove variable., Bruno Victal, 2023/02/26
- [bug#61829] [PATCH 06/11] services: base: Remove 'console-font-service' procedure., Bruno Victal, 2023/02/26
- [bug#61829] [PATCH 08/11] services: desktop: Remove 'gnome-desktop-service' procedure., Bruno Victal, 2023/02/26
- [bug#61829] [PATCH 10/11] services: desktop: Remove 'xfce-desktop-service' procedure., Bruno Victal, 2023/02/26
- [bug#61829] [PATCH 11/11] guix: packages: Remove 'origin-sha256' procedure., Bruno Victal, 2023/02/26
- [bug#61829] [PATCH 11/11] guix: packages: Remove 'origin-sha256' procedure.,
Simon Tournier <=
- [bug#61829] [PATCH 07/11] services: guix-publish: Remove 'compression-level' field., Bruno Victal, 2023/02/26