[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61752: [PATCH 2/8] gnu: Add emacs-cfrs.
From: |
Nicolas Goaziou |
Subject: |
bug#61752: [PATCH 2/8] gnu: Add emacs-cfrs. |
Date: |
Wed, 08 Mar 2023 16:33:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:
> ---
> +(define-public emacs-cfrs
Thank you. I applied your patch with a proper commit message.
> + (package
> + (name "emacs-cfrs")
> + (version "1.6.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/Alexander-Miller/cfrs")
> + (commit "f3a21f237b2a54e6b9f8a420a9da42b4f0a63121")))
We don't put raw commit hashes here. We either use a tag, or let-bind it
to `commit' symbol around the whole package definition. See
emacs-xyz.scm for a truck load of examples.
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1vf5zm82sx3m1yvq73km8ajapv6rnz41b1jrsif7kh0ijh9vk3qi"))))
> + (build-system emacs-build-system)
> + (inputs (list
Indentation is off here (newline missing before "(list"). Also, Emacs inputs
are actually propagated
inputs.
> + emacs-s
> + emacs-dash
> + emacs-posframe))
I re-ordered inputs alphabetically.
> + (home-page "https://github.com/Alexander-Miller/cfrs")
> + (synopsis "Child Frame Read String")
> + (description
> + "Simple alternative to read-string that allows reading input via a small
I turned this into a full sentence.
> +child-frame spawned at the position of the cursor. Its goal is to make the
Note: Texinfo requires two spaces after full stops.
Regards,
--
Nicolas Goaziou
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#61752: [PATCH 2/8] gnu: Add emacs-cfrs.,
Nicolas Goaziou <=