[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#62309] [PATCH core-updates v2 1/2] opensbi: Build with default gcc,
From: |
Maxim Cournoyer |
Subject: |
[bug#62309] [PATCH core-updates v2 1/2] opensbi: Build with default gcc, with microarch rv64g |
Date: |
Tue, 21 Mar 2023 12:07:05 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello!
Josselin Poiret <dev@jpoiret.xyz> writes:
> * gnu/packages/firmware.scm (make-opensbi-package): Remove specific #:xgcc for
> the cross-toolchain, there is not reason for it now. Also set the microarch
> to
> rv64g, so that it builds.
> ---
> gnu/packages/firmware.scm | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
> index 956ece5d6d..0b7fff035a 100644
> --- a/gnu/packages/firmware.scm
> +++ b/gnu/packages/firmware.scm
> @@ -486,7 +486,7 @@ (define* (make-opensbi-package platform name #:optional
> (arch "riscv64"))
> (native-inputs
> `(,@(if (and (not (string-prefix? "riscv64" (%current-system)))
> (string-prefix? "riscv64" arch))
> - `(("cross-gcc" ,(cross-gcc "riscv64-linux-gnu" #:xgcc gcc-7))
> + `(("cross-gcc" ,(cross-gcc "riscv64-linux-gnu"))
> ("cross-binutils" ,(cross-binutils "riscv64-linux-gnu")))
> '())))
> (arguments
> @@ -499,6 +499,11 @@ (define* (make-opensbi-package platform name #:optional
> (arch "riscv64"))
> `("CC=gcc"))
> "FW_PAYLOAD=n"
> "V=1")
> + ;; Direct __asm__ is used with fence.i instructions, which are not
> + ;; available in the generic riscv ISA. We need a micro-arch with
> + ;; support for it, and rv64g is the official ISA with support for
> + ;; fence.i.
> + #:configure-flags (list "-march=rv64g")
> #:phases
> (modify-phases %standard-phases
> (delete 'configure)
LGTM, thanks for expounding the comment as suggested!
--
Thanks,
Maxim
- [bug#62309] [PATCH core-updates 0/2] Fix qemu build, Josselin Poiret, 2023/03/20
- [bug#62309] [PATCH core-updates 2/2] u-boot: Fix build under Python 3.10., Josselin Poiret, 2023/03/20
- [bug#62309] [PATCH core-updates 1/2] opensbi: Build with default gcc, with microarch rv64g, Josselin Poiret, 2023/03/20
- [bug#62309] [PATCH core-updates 0/2] Fix qemu build, Maxim Cournoyer, 2023/03/20
- [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10., Josselin Poiret, 2023/03/21
- [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10., Maxim Cournoyer, 2023/03/21
- [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10., Josselin Poiret, 2023/03/21
- [bug#62309] [PATCH core-updates v2 2/2] u-boot: Fix build under Python 3.10., Maxim Cournoyer, 2023/03/22
- bug#62309: [PATCH core-updates 0/2] Fix qemu build, Ludovic Courtès, 2023/03/26