[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60756: [PATCH 0/2] Add x11-socket-directory-service-type.
From: |
Maxim Cournoyer |
Subject: |
bug#60756: [PATCH 0/2] Add x11-socket-directory-service-type. |
Date: |
Tue, 21 Mar 2023 16:50:15 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Bruno Victal <mirai@makinata.eu> writes:
> The x11-socket-directory-service misuses activation-service-type
> to create directories. This kind of usage is incorrect since
> activation-service-type does not depend on file-systems, hence incompatible
> with user defined /tmp mount.
>
> This commit turns x11-socket-directory-service into a shepherd one-shot
> service by defining a new x11-socket-directory-service-type.
>
> * gnu/services/desktop.scm (x11-socket-directory-service-type): New variable.
> (x11-socket-directory-service): Deprecate procedure.
> (desktop-services-for-system): Use new service-type.
> * gnu/tests/lightdm.scm: Ditto.
I've applied this series, with the small change:
--8<---------------cut here---------------start------------->8---
modified gnu/services/desktop.scm
@@ -1578,7 +1578,7 @@ (define sugar-desktop-service-type
(define x11-socket-directory-service-type
(let ((x11-socket-directory-shepherd-service
(shepherd-service
- (documentation "Create /tmp/.X11-unix for XWayland.")
+ (documentation "Create @file{/tmp/.X11-unix} for XWayland.")
(requirement '(file-systems))
(provision '(x11-socket-directory))
(one-shot? #t)
--8<---------------cut here---------------end--------------->8---
Thanks for the contribution and to Josselin for the review, which made
me much more confident to install it (along with the QA badge).
--
Thanks,
Maxim