[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#59938] [PATCH] add python-ogr2osm package
From: |
Nicolas Goaziou |
Subject: |
[bug#59938] [PATCH] add python-ogr2osm package |
Date: |
Sun, 23 Apr 2023 16:47:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
Patrick Noll <patrick@patricknoll.com> writes:
> +(define-public python-ogr2osm
Thank you.
Please note your commit message is not properly formatted. It should
look like:
gnu: Add python-ogr2osm.
* gnu/packages/geo.scm (python-ogr2osm): New variable.
Also, indentation is a bit off. You may want to use "guix style" command
to format the packge.
> + (propagated-inputs
> + (list python-gdal python-lxml))
AFAIK, python-gdal is not provided in Guix, so you would need to package
it as well. Also, the package itself probably requires gdal as an input.
> + (arguments '(#:tests? #f)) ; Tests not included in release tarball
Maybe it is better to get it from upsteram them. WDYT?
> + (home-page
> + "https://github.com/roelderickx/ogr2osm")
> + (synopsis
> + "Convert ogr-readable files like shapefiles into Openstreetmap(osm) format")
> + (description
> + "A tool for converting ogr-readable files into Openstreetmap(osm)
> format. Ogr2osm supports reading from ogr files like shapefiles or
> Postgres database. Ogr2osm converts data into osm or osm.pbf formats.
> A translation file can be used to manipulate the data during
> conversion.")
The description should consist of complete sentences. Also, sentences
need to be separated with two spaces.
Would you want to send an updated patch?
Regards,
--
Nicolas Goaziou
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#59938] [PATCH] add python-ogr2osm package,
Nicolas Goaziou <=