guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#63388] [PATCH] gnu: guile-gnutls: Update to 3.7.12.


From: Ludovic Courtès
Subject: [bug#63388] [PATCH] gnu: guile-gnutls: Update to 3.7.12.
Date: Wed, 10 May 2023 00:32:19 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hi Christopher,

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/packages/tls.scm (guile-gnutls): Update to 3.7.12.
> [source]: Switch to a tarball, to avoid a circular dependency if guile-gnutls
> is used in git-download.
> [arguments]: Remove phase changes for building from Git.
> [native-inputs]: Remove autoconf and automake as they're now unnecessary.

Excellent!  (Thanks, Simon!)

>      (source (origin
> -              (method git-fetch)
> -              (uri (git-reference
> -                    (url home-page)
> -                    (commit (string-append "v" version))))
> +              (method url-fetch)

Please add a comment stating why we’re using ‘url-fetch’, with a
reference to <https://issues.guix.gnu.org/63331>.

> +              (uri
> +               (string-append

Rather on the same line maybe?  :-)

Thanks for working on it!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]