guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#73901] [PATCH 0/4] gnu: yggdrasil: Update to 0.5.9.


From: Sharlatan Hellseher
Subject: [bug#73901] [PATCH 0/4] gnu: yggdrasil: Update to 0.5.9.
Date: Mon, 21 Oct 2024 08:18:55 +0100

Hi,

Some review points, but it looks fine in general.

Looks ok and trivial
- [PATCH 2/4] gnu: go-github-com-wlynxg-anet: Update to 0.0.5.
- [PATCH 3/4] gnu: go-github-com-arceliar-ironwood: Update to 
v0.0.0-20241016082300-f6fb9da97a17.

The project is quite active and big, maybe we may add more info into
description with some highlights of features. WDYT?
- [PATCH 1/4] gnu: Add go-github-com-coder-websocket.

--8<---------------cut here---------------start------------->8---
+     `(#:import-path "github.com/coder/websocket"))
--8<---------------cut here---------------end--------------->8---
I guess "guix import go" generates "(arguments (list ...))" style, let's
stick to that.

Looks ok. Maybe check if we have associated service and 0.5.9 did not
bring any breaking changes or new features in configuration.
- [PATCH 4/4] gnu: yggdrasil: Update to 0.5.9.

I could build it locally:
--8<---------------cut here---------------start------------->8---
successfully built 
/gnu/store/bk5ksmjyhza2dznnnmqhi0fxvb8snlvn-yggdrasil-0.5.9.drv
/gnu/store/grlv79cw4z3m60q2vgqshkk4dl3lxqn8-yggdrasil-0.5.9
--8<---------------cut here---------------end--------------->8---

Comments are optional, you don't have to send v2 if you decided to apply
changes reflecting them.

--
Thanks,
Oleg

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]