[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gwl-devel] [PATCH] workflow: Consider unspecified free inputs when

From: Ricardo Wurmus
Subject: Re: [gwl-devel] [PATCH] workflow: Consider unspecified free inputs when checking cache.
Date: Mon, 24 Jun 2019 15:54:02 +0200
User-agent: mu4e 1.2.0; emacs 26.2

Hi Kyle,

> When deciding whether a process is cached, we take into account the
> modification time and size of free inputs, but only those that are
> explicitly specified on the command line.  As a result, the same
> updated input file that would invalidate the cache when given
> explicitly to --input does _not_ invalidate the cache when not
> specified but instead picked from the current working directory.
> Correct this discrepancy by including unspecified free inputs in the
> cache prefix calculation.

Thank you for this patch and my apologies for the delay in reviewing the
change!  It took me a little too long to understand the problem and then
even longer to decide whether we should include this workaround or if
there was an alternative that could improve the handling of unspecified
inputs all together.

I ended up splitting it up into two commits: one that names the values,
the other to pass on the unspecified inputs to
make-process->cache-prefix.  I’m not sure if we should keep picking
inputs from the environment silently and by default, but your patch is
anyway more correct than what we had before.

Thanks again!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]