[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gwl/ui: Check for log-events configuration

From: Olivier Dion
Subject: Re: [PATCH] gwl/ui: Check for log-events configuration
Date: Sat, 04 Jun 2022 11:10:42 -0400

On Sat, 04 Jun 2022, Ricardo Wurmus <> wrote:
> Olivier Dion <> writes:
>> Some GWL sub-commands such as `graph' do not accept a log event 
>> configuration.
>> This results in returning `#f' from `(%config 'log-events)'
> I don’t understand how this leads to a problem.  Do any of the features
> of “graph” use “log-event”?

Yes.  `load-workflow' -> `load-workflow*' -> `load*' -> `log-event 'info
"Loading workflow file"'.

> Generally, I’d prefer to give “log-events” a better default.  I can’t
> imagine a situation where #F (rather than the empty list) would be
> appropriate.

The empty list would be a more sane choice I agree. I'll send a v2 with
this change.  Also, the `print?` predicate could be memoize with `mlambda'?

Olivier Dion

reply via email to

[Prev in Thread] Current Thread [Next in Thread]