[Gzz-commits] gzz/gzz/media/impl ScrollBlockManager.java

[Benja Fallenstein]

CVSROOT:        /cvsroot/gzz
Module name:    gzz
Changes by:     Benja Fallenstein <address@hidden>      02/10/11 10:21:33

Modified files:
        gzz/media/impl : ScrollBlockManager.java 

Log message:
        Fix the bug by changing ScrollBlockManager's semantics.
        This way, a) the file format is more consistent, and
        b) it seems to be the way *everybody* thinks it is now:
        SimpleTransientSpace in basalt/, the only other user of
        ScrollBlockManager.getSpan(...), ALSO thought it would
        take page offset and length and thus *HAD THE SAME BUG*.
        So, let's simply fix ScrollBlockManager's semantics and
        make the bug thusly go away in both places ;-)

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/gzz/gzz/gzz/media/impl/ScrollBlockManager.java.diff?tr1=1.7&tr2=1.8&r1=text&r2=text

Patches:
Index: gzz/gzz/media/impl/ScrollBlockManager.java
diff -c gzz/gzz/media/impl/ScrollBlockManager.java:1.7 
gzz/gzz/media/impl/ScrollBlockManager.java:1.8
*** gzz/gzz/media/impl/ScrollBlockManager.java:1.7      Fri Oct 11 09:37:42 2002
--- gzz/gzz/media/impl/ScrollBlockManager.java  Fri Oct 11 10:21:33 2002
***************
*** 38,44 ****
   */
  
  public class ScrollBlockManager {
! String rcsid = "$Id: ScrollBlockManager.java,v 1.7 2002/10/11 13:37:42 tjl 
Exp $";
      public static boolean dbg = false;
      final static void p(String s) { if(dbg) System.out.println(s); }
      final static void pa(String s) { System.out.println(s); }
--- 38,44 ----
   */
  
  public class ScrollBlockManager {
! String rcsid = "$Id: ScrollBlockManager.java,v 1.8 2002/10/11 14:21:33 benja 
Exp $";
      public static boolean dbg = false;
      final static void p(String s) { if(dbg) System.out.println(s); }
      final static void pa(String s) { System.out.println(s); }
***************
*** 386,392 ****
      }
  
      public static Span getSpan(Mediaserver ms, Mediaserver.Id id,
!                              int p0, int p1, int x, int y, int w, int h) {
  
        PageImageScroll block = null;
  
--- 386,394 ----
      }
  
      public static Span getSpan(Mediaserver ms, Mediaserver.Id id,
!                              int poffs, int plen, int x, int y, int w, int h) 
{
!     
!         int p0 = poffs, p1 = poffs+plen;
  
        PageImageScroll block = null;