Re: [Gzz] patch for libvob

[Tuomas Lukka]

On Tue, Apr 22, 2003 at 11:32:07AM +0300, Jukka Honkela wrote:
> 
> Here is a small patch for libvob, although somewhat broken one
> because it does not do any checks and is probably dependent on
> the shell in use etc..

Thank you for the patch.

> Anyhow, as some people, including me, do not have g++-3.2 but
> just g++ which happens to be 3.2, it'd be nice if the thing
> could be compiled without much modifications.

...
> +PREGCCVER=-3.2
> 
> +GCCVER=$(shell [ -z "`g++$(PREGCCVER) --version 2>/dev/null`" ] || echo 
> "$(PREGCCVER)")

> +CXX=g++$(GCCVER)

I don't quite understand what that's doing without unraveling this.
Could you also add a comment saying what that line actually does?

What about g++ -V3.2, would that be better?

Should we start using 3.3 now that it has hit debian?

> 
> Secondly, I added two lines for athlon XP and MP compiler flags
> (affects SSE usage, I think)

I've accepted that part, thank you.

        Tuomas