RE: [PATCH] 2.1.17 portability and core dump fixes

[Martin, Jason H]

I can confirm that 2.1.17 fails to build on HPUX due to INET_ADDRSTRLEN
being undefined. 

-Jason Martin

> -----Original Message-----
> From: 
> help-cfengine-bounces+jason.h.martin=cingular.com@gnu.org 
> [mailto:help-cfengine-bounces+jason.h.martin=cingular.com@gnu.
> org] On Behalf Of Joe Buehler
> Sent: Wednesday, December 14, 2005 4:41 AM
> To: help-cfengine@gnu.org
> Subject: [PATCH] 2.1.17 portability and core dump fixes
> 
> 
> Here are some patches to make 2.1.17 compile and run properly 
> under various non-linux UNIX's (Solaris, HPUX, AIX).  There 
> are also a couple fixes for core dumps that happen under AIX.
> 
> The maintainer(s) might do a grep for double semicolons (;;)
> in various places they don't need to be and get rid of them; 
> there are a fair number and they cause compiler warnings. One 
> place was considered an error by one of the compilers and is 
> removed in the attached patch.
> 
> You might also try valgrind on the code -- cfagent has a 
> number of memory leaks.  They sort of don't matter because 
> the program is not a daemon, but still...
> 
> In order:
> 
> acl.c
> 
> - prototype fix so it compiles
> 
> cf.defs.h
> 
> - elimination of illegal (in newer C standards) comma
> 
> cf.extern.h
> 
> - elimination of extraneous semicolon
> 
> cfagent.c
> 
> - null pointer deref fix
> 
> cfetool.c
> 
> - illegal use of computed value for array size
> - missing argument in printf() call
> 
> cfservd.c
> 
> - use of C++ comment syntax in C code
> 
> edittools.c
> 
> - use of == where = was intended (uninitialized variable)
> - illegal use of CURRENTITEM (it points to freed memory -- found
>   via insure++)
> 
> ifconf.c
> 
> - INET_ADDRSTRLEN appears to be a linuxism
> -- 
> Joe Buehler
>