Re: 2.1.17 cfservd.c connection memory leak

[Mark Burgess]

Joe, you're a saint and a hero. I can still see a small (1-3 byte)
memory leak when cfservd is active but I can't see where it might come
from.
M


On Thu, 2005-12-22 at 15:14 -0500, Joe Buehler wrote:
> This was found via a cfrun invocation:
> 
> \"/home/project-releases/tmp/cfengine-2.1.17/src/cfservd.c\", line 3367:
> (LEAK_FREE)
> >> free ((char *)conn);
> 
>   Memory leaked freeing block: malloc(16)
> 
>   Lost block : 0x200d1758 thru 0x200d1767 (16 bytes)
>                malloc(16), allocated at cfservd.c, 2471
>                           malloc()  (interface)
>           AuthenticationDialogue()  cfservd.c, 2471
>               BusyWithConnection()  cfservd.c, 1268
>                 HandleConnection()  cfservd.c, 1149
> 
>   Stack trace where the error occurred:
>                             free()  (interface)
>                       DeleteConn()  cfservd.c, 3367
>                 HandleConnection()  cfservd.c, 1173
> 
> The problem is that "conn" is being freed, but it contains
> a pointer to an object that was created via malloc:
> 
> conn->session_key = malloc(CF_BLOWFISHSIZE);