Re: bug#75970: closed ([PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.)

[Roman Scherer]

References: <877c67kte9.fsf@gmail.com>
        
<a85cf4325080efc3974b2b7b8c34d6aa7abac772.1738336212.git.roman@burningswell.com>
        <handler.75970.D75970.17385920673507.notifdone@debbugs.gnu.org>
User-Agent: mu4e 1.12.8; emacs 29.4
Thank you Oleg!

Date: Mon, 03 Feb 2025 16:00:01 +0100

help-debbugs@gnu.org (GNU bug Tracking System) writes:

> Your bug report
>
> #75970: [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.
>
> which was filed against the guix-patches package, has been closed.
>
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 75970@debbugs.gnu.org.
>
> --
> 75970: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75970
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
>
> From: Sharlatan Hellseher <sharlatanus@gmail.com>
> Subject: [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.
> To: 75970-done@debbugs.gnu.org
> Date: Mon, 03 Feb 2025 14:14:06 +0000 (45 minutes, 36 seconds ago)
>
>
> Hi Roman,
>
> Thank you for reporting this.
>
> To resolve build for hetznercloud-cli on aarch64-linux I've limited tests
> coverage in go-github-com-cespare-xxhash-v2 package with #:tests-subdirs
> parameter instead of deleting files as you proposed.
>
> Tested locally
> --8<---------------cut here---------------start------------->8---
>> ./pre-inst-env guix build --system=aarch64-linux hetznercloud-cli
> /gnu/store/vm5dmj6hi3147xxhmwiqc7z94yzx74rk-hetznercloud-cli-1.49.0
> --8<---------------cut here---------------end--------------->8---
>
> These commits fixed build hetznercloud-cli on aarch64-linux system and
> pushed to master:
> --8<---------------cut here---------------start------------->8---
> 97fee203a54 * master gnu: go-github-com-prometheus-client-golang: Skip one 
> more test.
> 5b9fa4a27c7 * gnu: go-github-com-cespare-xxhash-v2: Update to 2.3.0.
> 4ded4c6b713 * gnu: go-github-com-cespare-xxhash-v2: Skip dynamic and 
> benchmark tests.
> --8<---------------cut here---------------end--------------->8---
>
> Closing as resolved.
>
> --
> Oleg
>
> ----------
>
> From: Roman Scherer <roman@burningswell.com>
> Subject: [PATCH] gnu: go-github-com-cespare-xxhash-v2: Fix build on aarch64.
> To: guix-patches@gnu.org
> Cc: Roman Scherer <roman@burningswell.com>
> Date: Fri, 31 Jan 2025 16:11:26 +0100
> Date: Fri, 31 Jan 2025 16:11:26 +0100 (2 days, 23 hours, 48 minutes ago)
>
> * gnu/packages/golang-crypto.scm (go-github-com-cespare-xxhash-v2): Fix build 
> on aarch64.
>
> Change-Id: I348839621b1937618714d7ca5c6a49b291a27e70
> ---
>  gnu/packages/golang-crypto.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/golang-crypto.scm b/gnu/packages/golang-crypto.scm
> index 75c56684d4..3b0f521244 100644
> --- a/gnu/packages/golang-crypto.scm
> +++ b/gnu/packages/golang-crypto.scm
> @@ -442,7 +442,12 @@ (define-public go-github-com-cespare-xxhash-v2
>         (sha256
>          (base32 "1f3wyr9msnnz94szrkmnfps9wm40s5sp9i4ak0kl92zcrkmpy29a"))
>         (modules '((guix build utils)))
> -       (snippet '(delete-file-recursively "xxhashbench"))))
> +       (snippet
> +        `(begin
> +           (delete-file-recursively "xxhashbench")
> +           (when ,(target-aarch64?)
> +             ;; Fails on aarch64 with: collect2: fatal error: cannot find 
> ‘ld’
> +             (delete-file-recursively "dynamic"))))))
>      (arguments
>       (list
>        #:import-path "github.com/cespare/xxhash/v2"
>
> base-commit: bdd6760b8c46e59f86415d67981acb6f77e9ed22

signature.asc
Description: PGP signature