[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Gnatsweb attachment handling broken by gnatsd

From: Yngve Svendsen
Subject: Re: Gnatsweb attachment handling broken by gnatsd
Date: Sun, 22 Apr 2001 20:34:11 +0200

At 18:27 22.04.2001 +0200, Milan Zamazal wrote:
I think it's there because unknown fields are added there and they
should be prevented looking like real fields, they should be a clear
part of the `Unformatted' field.

    YS> By doing the following to addLineToPR in pr.c (basically
    YS> commenting out the space-adding code) and rebuilding gnatsd,
    YS> attachment handling worked again:

I don't think doing this is a good idea.

    YS> The easiest way to fix Gnatsweb would be to remove this code
    YS> from pr.c. Working around it in Gnatsweb would take a bit of
    YS> coding and very likely affect performance a lot.

As it was already suggested, it's likely that attachements will be
handled in a special way in GNATS 4.x.  As for GNATS 4.0, I think
Gnatsweb should be fixed.  I don't know anything about the attachement
handling in Gnatsweb, but I think it's not a good ideat to store them in
the `Unformatted' field.  I'd suggest considering to require having the
`Attachement' field in `dbconfig' (I might add it to the default
`dbconfig' if it proves useful).

I agree. It is not a good idea to store them in the Unformatted field. However, rewriting the attachment handling to use a special "Attachment" field would require a fair bit of work. Since it is likely that attachment handling will be implemented in Gnats itself at some point, I'll look into a quick fix, by having Gnatsweb strip off the leading spaces during parsing.

- Yngve

reply via email to

[Prev in Thread] Current Thread [Next in Thread]