[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Current Gnats 4 CVS broken on Solaris
From: |
Yngve Svendsen |
Subject: |
Re: Current Gnats 4 CVS broken on Solaris |
Date: |
Tue, 12 Jun 2001 22:25:02 +0200 |
At 17:19 12.06.2001 +0200, Yngve Svendsen wrote:
At 17:15 10.06.2001 +0200, Milan Zamazal wrote:
>>>>> "YS" == Yngve Svendsen <address@hidden> writes:
YS> Sorry, but it seems the configure check for %z support isn't
YS> working right.
You're right. strftime is going to become my nightmare. :-| I tried to
fix it and also added a patch by Carl enabling numeric time zones also
on systems not supporting `%z'. Please try whether it works or not.
Unfortunately, the nightmare continues. "make all" results in the
following on a Solaris 7 system:
[snip]
On some systems, Solaris among them, isdigit() requires an explicit cast to
int. The very simple patch below fixes the problem and makes the current
GNATS 4 compile on both Solaris and Linux.
I have compiled and done some testing, and as far as I can tell, all is now
well on systems that don't support %z.
- Yngve
Index: misc.c
===================================================================
RCS file: /cvs/gnats/gnats/gnats/misc.c,v
retrieving revision 1.28
diff -u -p -r1.28 misc.c
--- misc.c 2001/06/10 17:15:47 1.28
+++ misc.c 2001/06/12 20:21:01
@@ -567,7 +567,7 @@ gnats_strftime (char *s, size_t size, co
{
char buf[16];
strftime (buf, 16, "%z", brokentime);
- have_strftime_with_z = isdigit (buf[1]);
+ have_strftime_with_z = isdigit ((int) (buf[1]));
}
if (have_strftime_with_z)