[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: Patch: Fix user authentication + MKDB
From: |
Pankaj K Garg |
Subject: |
RE: Patch: Fix user authentication + MKDB |
Date: |
Fri, 27 Sep 2002 10:37:04 -0700 |
Thanks for testing the patch.
> ...
> signal Segmentation fault at >*[strlen, 0x3ff800d1d30] ldq_u
> t0, 0(a0)
> (dbx) where
> > 0 strlen(0x120033f58, 0xf, 0xf, 0x140032660, 0x1200340d4)
> [0x3ff800d1d30]
> 1 xstrdup() ["../../gnats-4/libiberty/xstrdup.c":6, 0x1200340b4]
> 2 copy_adm_entry() ["../../gnats-4/gnats/adm.c":6, 0x12001a1f8]
> 3 get_responsible_address()
> ["../../gnats-4/gnats/mail.c":6, 0x120026504]
> 4 get_one_responsible_addr()
> ["../../gnats-4/gnats/mail.c":6, 0x120026738]
> 5 get_responsible_addr() ["../../gnats-4/gnats/mail.c":6,
> 0x120026b60]
> 6 gnatsdChdb() ["../../gnats-4/gnats/cmds.c":6, 0x12000b5a0]
> 7 GNATS_user() ["../../gnats-4/gnats/cmds.c":6, 0x12000aae8]
> 8 serverMainLoop() ["../../gnats-4/gnats/gnatsd.c":6, 0x120009ca0]
> 9 main() ["../../gnats-4/gnats/gnatsd.c":6, 0x12000a0e8]
> (dbx)
>
I was not able to replicate this problem even with LIB_CRYPT set
to 0. But, I suspect this is happening because I changed the
fields routines to return a NULL in case of an empty field. Sounds
like a bad idea, as obviously some routines depend on it being
non-NULL.
So, I've changed this in a new patch. Now, for an empty field
we return an empty string (""). Hopefully, this should fix
things. Please try the attached patch and let me know.
> As nn aside: if gnatsd for some reason cannot access the
> responsible file
> (or the gnatsd.user_access file for that matter) it silently
> ignores the fact
> which seems rather strange (but has nothing to do with your patch).
Yes, we should log it somewhere. I can take care of this after this
round of changes stabilize.
> By the way, don't forget the GNATS_help() function at the end
> of cmds.c
> and the manual of course (I'm willing to help with that).
I made some changes to the GNATS_help() function. We can fix the manual
once we stabilize the code.
Regards
Pankaj
patchfile.out
Description: Text document
- Patch: Fix user authentication + MKDB, Pankaj K Garg, 2002/09/23
- Re: Patch: Fix user authentication + MKDB, Lars Henriksen, 2002/09/25
- Re: Patch: Fix user authentication + MKDB, Dirk Schenkewitz, 2002/09/25
- RE: Patch: Fix user authentication + MKDB, Pankaj K Garg, 2002/09/25
- RE: Patch: Fix user authentication + MKDB, Pankaj K Garg, 2002/09/26
- RE: Patch: Fix user authentication + MKDB, Yngve Svendsen, 2002/09/27
- Re: Patch: Fix user authentication + MKDB, Lars Henriksen, 2002/09/27
- RE: Patch: Fix user authentication + MKDB,
Pankaj K Garg <=
- Re: Patch: Fix user authentication + MKDB, Lars Henriksen, 2002/09/27
- RE: Patch: Fix user authentication + MKDB, Pankaj K Garg, 2002/09/27
- Re: Patch: Fix user authentication + MKDB, Lars Henriksen, 2002/09/29
- RE: Patch: Fix user authentication + MKDB, Pankaj K Garg, 2002/09/29
RE: Patch: Fix user authentication + MKDB, Pankaj K Garg, 2002/09/25