Re: defadvice question.

[Kevin Rodgers]

Michal wrote:
> Hallo Kevin!
>
> Kevin Rodgers <kevin.d.rodgers@gmail.com> writes:
>
> > > > The tricky part is the "...".  You could copy the entire interactive form from
> > > > cvs-checkout source in pcvs.el, but that defeats the whole purpose of using
> > > > advice.  You might be able to work around it like this:
>
> then You rather meant just to copy these parameters by hand, didn't You?
> sorry for my misunderstanding

No problem, Michal.

> > What does M-: (getenv "CVSROOT") display?
> "michal@cvs.repository:/var/local/cvsroot"
> > cvs-checkout reads several arguments interactively, with different functions
> > that use different history variables.  Which prompt are you interested in,
> > "CVS Root: ", "Module(s): ", or "CVS Checkout Directory: "?
>
> "CVS Root:" one

That is read with read-string, which uses minibuffer-history, so we got that
part right.

The problem is that I forgot to include this from your original post:
(ad-activate 'cvs-checkout)

I prefer to use the activate flag:
(defadvice cvs-checkout (before minibuffer-history activate)
  ...)

--
Kevin Rodgers
Denver, Colorado, USA