Re: Dir-Locals + Editorconfig Changes in Emacs 26

[Jay Kamat]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Jay Kamat <jaygkamat@gmail.com>
>> Date: Mon, 02 Oct 2017 13:55:33 -0400
>> 
>> However, since emacs 26, this is reversed, where dir-locals is applied
>> first, rather than last, and so editorconfig overrides dir-locals. I
>> have filed a bug report to the project here to document it:
>> https://github.com/editorconfig/editorconfig-emacs/issues/141
>> 
>> The reason that this is significant is that editorconfig not only lets
>> you configure on a per-project basis, but recursively on a per machine
>> basis as well, so if you have a editorconfig file in your home directory
>> (as many people do) those settings will apply for every file on your
>> system, overwriting dir-locals settings. Since dir-locals is more
>> powerful and project-specific, I would much prefer dir-locals to
>> override editorconfig.
>> 
>> Editorconfig seems to apply on the 'after-change-major-mode' hook, as
>> shown below:
>
> Could it be that the major mode hook is now called twice, and
> Editorconfig fails to notice that one of these calls is to turn the
> mode off?

Is `after-change-major-mode' getting called twice in emacs 26, but not
25? I can't seem to find a related news entry about the change, could
you point me to more information about that?

I took a look at the implementation of `after-change-major-mode', and I
found `change-major-mode-after-body-hook' nearby, which seems to do what
I want at a first glance (running hooks before dir-locals is set). Does
changing the hook seem like the proper way to solve this?

Thanks,
-Jay