help-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bookmarks in EWW


From: Michael Heerdegen
Subject: Re: Bookmarks in EWW
Date: Thu, 26 Mar 2020 02:09:03 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

> > +  ;; Emacs bookmarks support
> > +  (defvar bookmark-make-record-function)
> > +  (setq-local bookmark-make-record-function #'eww-bookmark-make-record)
>
> No need for the `defvar` here.

> > Do I need to declare `bookmark-make-record-function' as special when
> > setting with `setq-local' (that's what doc-view does)?
>
> No.  buffer-localness is a concept that only applies to dynamically
> scoped variables anyway, so if you need it it's a sign that we should
> improve something somewhere.

Well, if I remove that defvar as you suggest, leaving none in that file,
I get

  make[2]: Entering directory '/home/micha/software/emacs/lisp'
    ELC      net/eww.elc
  
  In eww-mode:
  net/eww.el:893:47: Warning: assignment to free variable
      ‘bookmark-make-record-function’


Michael.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]