[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: xref in GNU ELPA broken on Emacs 26

From: Dmitry Gutov
Subject: Re: xref in GNU ELPA broken on Emacs 26
Date: Tue, 19 Oct 2021 17:23:27 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 19.10.2021 16:27, Stefan Monnier via Users list for the GNU Emacs text editor wrote:
I suspect that you can get the same without `eval` with something like:

     (defmacro xref--defstruct (name &rest fields)
       (declare (indent 1))
       `(cl-defstruct ,(if (>= 27 emacs-major-version) name
                         (remq (assq :noinline name) name))

     (xref--defstruct (xref-item
                       (:noinline t)
                       (:constructor xref-make (summary location)))
       "An xref item describes a reference to a location somewhere."
       summary location)

     (xref--defstruct (xref-match-item
                       (:noinline t)
                       (:include xref-item)
                       (:constructor xref-make-match (summary location length)))
        "A match xref item describes a search result."

Nice! Thanks, Stefan.


I'm going to push this change now (with a couple of tweaks), to get the fix out sooner. But let me know if the soon-to-be-released version 1.3.1 still has problems.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]