[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Please test gsasl 0.2.29 release candidate!

From: Simon Josefsson
Subject: Re: Please test gsasl 0.2.29 release candidate!
Date: Mon, 13 Oct 2008 17:26:39 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux)

Adam Strzelecki <address@hidden> writes:

>>> # if defined(_WIN32) && !defined(GSASL_STATIC)
>>> to
>>> # if defined(_MSC_VER) && !defined(GSASL_STATIC)
>>> (..)
>> I'll look into this approach.
> Changing _WIN32 -> _MSC_VER in GSASL_API block would be IMHO the
> safest approach to set the dllexports just for Visual Studio, without
> altering the project files actually and with minimum changes to
> 0.2.28. I think I cannot tinker anything smarter for now.

I agree.  I've pushed the patch, and will prepare a release candidate
after I have tested it myself first.

>>> I'm fine with rest of the changes to drop Perl dependency. I remember
>>> you were asking for having this Perl script in gsasl as is was done
>>> in
>>> libidn though, and now we drop it back :>
>> I didn't know we could do without the perl script. :)
> The perl script here was just needed actually to get the PACKAGE name
> and PACKAGE_VERSION, since Visual Studio isn't scriptable at all.
> I think static config.h is just fine.

I hard coded PACKAGE to "libgsasl" since that is unlikely to change, and
changed PACKAGE_VERSION to GSASL_VERSION to avoid the need to encode the
version in MSVS config.h.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]