Re: problem with #include_next<stdint.h> in /usr/include/idn-int.h

[Simon Josefsson]

Remko van der Vossen <address@hidden> writes:

> On Tue, Jun 19, 2007 at 11:57:21PM +0200, Remko van der Vossen wrote:
>> Hello everyone,
>> 
>> I have a problem with using libidn;
>> 
>> I tried to compile mutt (1.5.9 and CVS) with libidn support, but got the
>> following error in both cases:
>> 
>> gcc -DPKGDATADIR=\"/usr/share/mutt\" -DSYSCONFDIR=\"/etc\"
>> -DBINDIR=\"/usr/bin\" -DMUTTLOCALEDIR=\"/usr/share/locale\"
>> -DHAVE_CONFIG_H=1 -I.  -I. -I. -I./imap  -Iintl -I./intl -I/usr/include
>> -Wall -pedantic -O -march=pentium3 -pipe -O3 -g -MT addrbook.o -MD -MP
>> -MF .deps/addrbook.Tpo -c -o addrbook.o addrbook.c
>> In file included from /usr/include/idna.h:31,
>>                  from mutt_idna.h:26,
>>                  from addrbook.c:28:
>> /usr/include/idn-int.h:48:27: error: no include path in which to search
>> for stdint.h
>> 
>> /usr/include/idn-int.h uses a #include_next<stdint.h> which fails
>> because the include path past /usr/include is empty as is evident from
>> the gcc call.
>> 
>> I do not understand why idn-int.h uses #include_next instead of
>> #include. Is this a bug, or is there something wrong in the way mutt
>> uses libidn, or something in the layour of my include files?
>> 
>> When I change the #include_next<stdint.h> to an #include<stdint.h> I can
>> compile mutt without problems.
>> 
>> Please see: http://bugs.sourcemage.org/show_bug.cgi?id=13857
>
> Hello again everyone,
>
> The problem seems to persist after version 1.0 of libidn. Were the
> proposed changes not committed or not effective? I still receive the
> same error when trying to compile mutt with libidn support.

Hi!  Sorry I dropped that ball on this, and thanks for getting back.

I have now installed the patch below that may solve this, and
regenerated today's snapshot, could you try this one and let us know how
it works?

http://daily.josefsson.org/libidn/libidn-20070831.tar.gz

/Simon

commit 12f2443a37b9e6c95022e503f7853bd02110865e
Author: Simon Josefsson <address@hidden>
Date:   Fri Aug 31 11:15:07 2007 +0200

    Avoid using #include_next in idn-int.h when looking for stdint.h.
    Reported by Remko van der Vossen <address@hidden> in
    <http://thread.gmane.org/gmane.comp.gnu.libidn.general/65>,
    this tiny patch was suggested by Bruno Haible in
    <http://permalink.gmane.org/gmane.comp.lib.gnulib.bugs/10602>.

diff --git a/lib/Makefile.am b/lib/Makefile.am
index b1756bd..01ff47f 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -37,7 +37,7 @@ nodist_include_HEADERS = $(idn_int)
 
 idn-int.h:
        if test -n "$(STDINT_H)"; then \
-               cp gl/stdint.h idn-int.h; \
+               sed -e s/include_next/include/ gl/stdint.h > idn-int.h; \
        else \
                echo '#include <stdint.h>' > idn-int.h; \
        fi