[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-librejs] Page never renders with LibreJS extension enabled

From: Loic J. Duros
Subject: Re: [Help-librejs] Page never renders with LibreJS extension enabled
Date: Tue, 06 Nov 2012 06:04:04 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

mark burdett <address@hidden> writes:

> Hi, I am using LibreJS 4.9 and Firefox 16.0.2
> I made a test page here which should reproduce the issue:
> --mark B.


Thanks for taking the time to create the test pages. The issue is that
LibreJS expects a third column that will contain a link to the
source. It actually never checks the sources are valid but expects the
column to be there in the rows, as you can see in the docs:

That's a bug because it should be able to either fail silently (without
blocking the loading of the page) or it should accept it. I made a patch
for version 4.9.1 to accept the web label regardless of whether the
source column is present or not, and your page now works fine with it.

With version 4.9, you could bypass the issue by adding this at the end of
   each <tr>:
<td><a href="#">source</a></td>
or whatever you like in the text, and it should load properly.

This page will load:

But the original doesn't:

I'll push version 4.9.1 either today or tomorrow anyway so that this
issue doesn't reoccur with someone else.

Unrelated: You seem to be using Drupal for this website. Have you found
a way to dynamically update the list of JavaScript files according to
the new random names generated for the JavaScript files? This is
something that's been on my list for a long time.

Thanks again for your help spotting this bug!


> On 11/05/2012 06:13 PM, Loic J. Duros wrote:
>> Hi Mark:
>> Thanks for reporting this issue. First of all, may I ask you what
>> version of LibreJS you are using as well as what version of
>> Firefox/IceCat/IceWeasel/Abrowser you are using? 
>> Whenever LibreJS encounters a link with the rel="jslicense", it will
>> attempt to read that page and return a list of allowed scripts. Because
>> LibreJS needs to figure out what scripts are allowed before it actually
>> passes the response body (the HTML) back to Firefox for parsing,
>> it will be "spinning" until the job is done. If the page is
>> unresponsive, then it should spin like this for a while until a timer
>> times out (about 30 to 60 seconds, I believe, although I'll check in the
>> code again.)
>> I just tested LibreJS 4.9 on the following page and could not reproduce
>> the issue
>> As you can see on that page, there is a link for the licenses that leads
>> to the following:
>> There is a good chance you may have found a bug in LibreJS with your
>> particular setup and the main page along with the js web labels
>> page. The first thing to check is whether the <a> tag actually links to
>> an existing html page and that this page is available. I'd be interested
>> if you were willing to provide a copy of both the main page and the js
>> web labels page to this mailing list or to me personally if you don't
>> want to share it. Or maybe you could create a simpler case that
>> reproduces the issue so we can help you troubleshoot it?
>> Thanks again for reporting this issue, and above all for your interest
>> in making your free JavaScript detectable!
>> Loic
>> mark burdett <address@hidden> writes:
>>> Hi, I am trying to make the javascript on a site compatible with LibreJS
>>> by adding appropriate metatags etc.  I got the sylized comment in HTML
>>> working just fine. However, as soon as I add the link to the web label
>>> page - <a href="/librejs/jslicense" rel="jslicense">JavaScript license
>>> information</a> - Firefox fails to render the page when LibreJS is
>>> enabled.  The page is white and the progress indicator just spins forever.
>>> Does anyone have suggestions for how to debug this issue?
>>> Thanks,
>>> --mark B.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]