Re: patch for a new function $(md5 )

[Tim Murphy]

Hi,

This is just an opinion - doesn't carry any weight with the maintainers so
take it as such:

A Plugin?
-------------
I suggest that this is an idea candidate for a gmake plugin to be loaded
with the new(ish) "load" directive.  This way you can implement it and
people can use it without having to have a great debate about whether it
really truly fits in the core gmake.  If it proves to be widely used and
useful then it's more obvious to the maintainers that they might want to
make it a part of the default in future.

How it Works
---------------------
If it was me, I'd want to do $(md5 $(cat file1 file2)) preferably so that
it can be used in other situations e.g. to make a unique directory name
that's based on some other pair of paths that would be too long if joined
together..  If this doesn't seem feasible because one wants to md5 huge
binary files (seems a bit of a dubious thing to do during parsing) then I
think it should be $(md5file file1 file1) to indicate precisely what the
input is and that it's not useful for my use cases - only yours.

I can also imagine wanting to use something a lot faster and simpler than
md5 if I was purely interested in hashing and not in cryptographic security
of the hash - e.g. murmur.

Regards,

Tim

On 23 January 2015 at 13:26, Pierre Lindenbaum <
address@hidden> wrote:

> Hi all,
>
> I hope it's the right place to propose a patch. (I tried to register an
> account on https://savannah.gnu.org/account/register.php but I cannot
> beyond that page due to http://savannah.gnu.org/support/?108658 )
>
> find in attachement a patch for a function ($md5 )  that compute the md5
> checksum string of the arguments.
> It can be used to create filenames.
> My sources are also available at https://github.com/lindenb/
> make/compare/md5
> I've added a test, two sources md5.c and md5.h, updated the manual,
> Makefile.am, ...
> The original MD5 code comes from http://www.ncbi.nlm.nih.gov/
> IEB/ToolBox/CPP_DOC/lxr/source/src/util/md5.cpp released in the public
> domain.
>
> $ cat Makefile
> SRC=file.c load.c
> $(md5 ${SRC}): ${SRC}
>     echo $@
>
> $ make
> echo 6102b17725943449a8a77bf6cf05e023
> 6102b17725943449a8a77bf6cf05e023
>
> $ echo -n "file.c load.c" | md5sum
> 6102b17725943449a8a77bf6cf05e023  -
>
> Pierre L
>
>
> _______________________________________________
> Help-make mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/help-make
>
>


-- 
You could help some brave and decent people to have access to uncensored
news by making a donation at:

http://www.thezimbabwean.co.uk/friends/