4.2.1 recipe for target failed message [was: 4.1 recipe for target failed message]

[Jelsyd]

Hi Paul,

I tested make 4.2.1 with both VIM (8.0) and Emacs (24.5.1) and the new format 
is still recognized by both and they try (and fail) to jump to the error 
location:
"*** [Makefile" in Emacs
"make: *** [Makefile" in VIM

I myself are also rarely interested in the location of the failed 
recipe/target, while this interaction between make and the editors does cause 
me to break precious flow, while closing vacuously opened editor (mini-)buffers.

I tested the format "<file> line <line>", which seems to be working, as in 
being ignored by both VIM and Emacs.

Best regards,
Jelsyd

--- job.c
+++ job.c
@@ -494,8 +494,9 @@
nm = _("<builtin>");
else
{
- char *a = alloca (strlen (flocp->filenm) + 1 + 11 + 1);
- sprintf (a, "%s:%lu", flocp->filenm, flocp->lineno + flocp->offset);
+ const char *fmt = _("%s line %lu");
+ char *a = alloca (strlen (flocp->filenm) + (strlen (fmt) - 5) + 11 + 1);
+ sprintf (a, "%s line %lu", flocp->filenm, flocp->lineno + flocp->offset);
nm = a;
}



> On Sun, 2014-10-12 at 23:43 +0000, Karl Berry wrote:
>> make 4.1 now outputs lines like:
>> ./Common.mak:144: recipe for target 'whatever' failed
>>
>> which is likely to be immediately followed by a line like:
>> make: [whatever] Error 1 (ignored)
>
> I thought that being able to jump to the rule in the makefile would be
> helpful, but in the end I think it ends up being more annoying
> (especially because the pathname is not always right, and so Emacs often
> can't find the makefile anyway).
>
> So, I combined these two lines into a single line which won't be
> recognized by normal error line parsers (such as Emacs) but can still be
> interpreted (hopefully) by users who want to find the rule:
>
> make: [Makefile:22: target] Error 1
>
> etc.
>
> This will be in the next release.


Sent with [ProtonMail](https://protonmail.com) Secure Email.