[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wrong free in shishi_krberror_pretty_print

From: Simon Josefsson
Subject: Re: wrong free in shishi_krberror_pretty_print
Date: Fri, 21 Apr 2006 15:33:43 +0200
User-agent: Gnus/5.110005 (No Gnus v0.5) Emacs/22.0.50 (gnu/linux)

Elrond <address@hidden> writes:

> Hi,
> krberror.c, line 1199 (as in the debian/0.0.24 tar.gz)
> Function shishi_krberror_pretty_print, first free() in this
> function.
>       res = shishi_krberror_etext(&buf);
>       ...
>       free(buf);
> buf is not set, if shishi_krberror_etext fails.


> Not to mention, that the previous use of
> shishi_krberror_etext in this function looks a bit leaky.

Yup, and it would also crash on non-successful return codes.  Fixes.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]